Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configure messaging when creating services #1007

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 8, 2024

Closes #1002

Summary of Changes

  • It's now possible to configure messaging (logging/user messaging) for when creating services.
  • The runner now uses the MessagingProvider instead of handling messaging on its own.

Copy link

github-actions bot commented Apr 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.11s
✅ TYPESCRIPT eslint 5 0 0 4.48s
✅ TYPESCRIPT prettier 5 0 0 1.15s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ef4bb6f) to head (f926e22).
Report is 151 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1007   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           98        98           
  Lines        18666     18743   +77     
  Branches      3855      3859    +4     
=========================================
+ Hits         18666     18743   +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review April 8, 2024 09:06
@lars-reimann lars-reimann merged commit 61fd8e6 into main Apr 8, 2024
7 checks passed
@lars-reimann lars-reimann deleted the logger-config branch April 8, 2024 09:07
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging/toasts via services.shared.lsp.Connection
1 participant